[battery_plus_linux] rename plugin class#586
Merged
jpnurmi merged 3 commits intofluttercommunity:mainfrom Nov 2, 2021
Merged
Conversation
vbuberen
reviewed
Oct 28, 2021
Collaborator
vbuberen
left a comment
There was a problem hiding this comment.
I believe this package naming was fine with Plus word in its classes and it is just the name in pubspec had to be changed instead. Same applies to other plugins where you spotted the inconsistency in naming, since these are plus plugins now, not the original ones anymore.
Member
|
@jpnurmi can you test and approve this? I think we decided to name it BatteryPlus but you know it better. |
Member
+1 for keeping the class name. The fix will be simpler, and we have been specifically renaming classes to add the Plus suffix. |
This reverts commit 9737399.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes naming issue in
battery_plus_linux. It'spubspec.yamlstates that the plugin's class name isBatteryLinux, however throughout the code it wasBatteryPlusLinux. For consistency with Linux implementations of other plugins, that do not usePlusin the name, I've removed that as well (instead of just renaming plugin's class namein
pubspec.yaml).Without this building
battery_plus_exampleon Mac fails with:Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?